Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore!: remove pydantic v1 validator arg helpers #3615

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Chore!: remove pydantic v1 validator arg helpers #3615

merged 5 commits into from
Jan 23, 2025

Conversation

georgesittas
Copy link
Contributor

@georgesittas georgesittas commented Jan 10, 2025 •
edited
Loading

@georgesittas georgesittas marked this pull request as draft January 10, 2025 18:50
@georgesittas georgesittas force-pushed the jo/address_pydantic_v1_tech_debt branch 2 times, most recently from af7b9ec to 48c69b6 Compare January 14, 2025 20:57
@georgesittas georgesittas marked this pull request as ready for review January 14, 2025 21:00
@georgesittas georgesittas requested a review from a team January 14, 2025 21:20
@georgesittas georgesittas force-pushed the jo/address_pydantic_v1_tech_debt branch from 48c69b6 to fc35f96 Compare January 17, 2025 20:49
izeigerman
izeigerman reviewed Jan 20, 2025
View reviewed changes
sqlmesh/dbt/target.py Outdated Show resolved Hide resolved
izeigerman
izeigerman reviewed Jan 20, 2025
View reviewed changes
sqlmesh/dbt/target.py Outdated Show resolved Hide resolved
@georgesittas georgesittas force-pushed the jo/address_pydantic_v1_tech_debt branch from fc35f96 to bb72cfe Compare January 23, 2025 13:40
@georgesittas georgesittas force-pushed the jo/address_pydantic_v1_tech_debt branch from 0827b6c to 99b6da3 Compare January 23, 2025 17:20
@georgesittas georgesittas force-pushed the jo/address_pydantic_v1_tech_debt branch from 99b6da3 to 5303811 Compare January 23, 2025 17:26
@georgesittas georgesittas merged commit f5558b6 into main Jan 23, 2025
21 checks passed
@georgesittas georgesittas deleted the jo/address_pydantic_v1_tech_debt branch January 23, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izeigerman izeigerman izeigerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tech debt related to Pydantic v1
2 participants
@georgesittas @izeigerman