Issue977: add_rays_from_diagnostic(), poly2d_check and poly2d_sample, color cycling fixed

[Didou09]

Main changes:

• tf.data.poly2d_check() implemented, for:

  • clockwise vs ccw
  • closed vs open
  • dimensional checks

• tf.data.poly2d_sample() implemented, for:

  • sampling edge (outline)
  • sampling surface

• add_diagnostic_rays() implemented, for:

  • creating shape_cam + (nstart, nend) array of rays for each pixel
  • only handle a single optics per pixel so far (user-defined using index)

• Unit tests added for add_diagnostic_rays()

• color cycling for LOS fixed

• Better error msg for add_rays()

• Minor debug of user_limits for vos computation

• Minor cleanup of variable names

Issues:

Fixes, in devel, issues:

• Complete add_rays_from_diagnostic() with other strategies + collimator cameras #977
• Number of LOS > 7 creates color cycle crash #1002

[pep8speaks]

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file tofu/data/_class00_poly2d_check.py:

Line 189:27: W292 no newline at end of file

• In the file tofu/data/_class00_poly2d_sample.py:

Line 442:14: W292 no newline at end of file

• In the file tofu/data/_class08_generate_rays.py:

Line 301:80: E501 line too long (80 > 79 characters)

• In the file tofu/data/_class8_plot.py:

Line 623:41: E228 missing whitespace around modulo operator
Line 778:45: E228 missing whitespace around modulo operator
Line 1188:37: E228 missing whitespace around modulo operator
Line 1212:38: E228 missing whitespace around modulo operator
Line 1254:37: E228 missing whitespace around modulo operator
Line 1280:42: E228 missing whitespace around modulo operator
Line 1329:51: E228 missing whitespace around modulo operator
Line 1355:52: E228 missing whitespace around modulo operator

• In the file tofu/data/_utils_surface3d.py:

Line 438:53: W292 no newline at end of file

• In the file tofu/tests/tests08_diagnostics/test_01_diagnostics.py:

Line 824:80: E501 line too long (84 > 79 characters)
Line 829:80: E501 line too long (81 > 79 characters)
Line 830:80: E501 line too long (82 > 79 characters)
Line 833:25: E228 missing whitespace around modulo operator

Comment last updated at 2025-01-13 01:09:21 UTC

[Didou09]

Ready