Skip to content

Commit

Permalink
Ignore as_needed in ld_add_file_list
Browse files Browse the repository at this point in the history
After the change to DT_NEEDED I get warnings for some functions.
The reason is that libc.so on my machine contains:
GROUP ( /lib64/libc.so.6 /usr/lib64/libc_nonshared.a  AS_NEEDED ( /lib64/ld-linux-x86-64.so.2 ) )

Before the change to DT_NEEDED we solved the symbols because the
/lib64/libc.so.6 file has as DT_NEEDED set for ld-linux-x86-64.so.2
The above AS_NEEDED section was not followed so symbols in this
file gives a warning.
Currently fixed by including AS_NEEDED files.
  • Loading branch information
hermantb committed Nov 8, 2023
1 parent 0f29dbc commit ded713e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tccelf.c
Original file line number Diff line number Diff line change
Expand Up @@ -3877,8 +3877,9 @@ static int ld_add_file_list(TCCState *s1, const char *cmd, int as_needed)
if (ret)
goto lib_parse_error;
} else {
/* TODO: Implement AS_NEEDED support. Ignore it for now */
if (!as_needed) {
/* TODO: Implement AS_NEEDED support. */
/* DT_NEEDED is not used any more so ignore as_needed */
if (1 || !as_needed) {
ret = ld_add_file(s1, filename);
if (ret)
goto lib_parse_error;
Expand Down

0 comments on commit ded713e

Please sign in to comment.