Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lodash to 4.17.5 for vulnerability fix #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update lodash to 4.17.5 for vulnerability fix #19

wants to merge 1 commit into from

Conversation

tinder-andreismailyan
Copy link

chris--young
chris--young approved these changes May 10, 2018
View reviewed changes
Copy link
Collaborator

@chris--young chris--young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chris--young
Copy link
Collaborator

For reference, this is the vulnerability he’s referring to https://nodesecurity.io/advisories/577.

We’re technically already ok since this module doesn’t use any of the methods in lodash that are vulnerable, but it’s good to upgrade anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris--young chris--young chris--young approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinder-andreismailyan @chris--young