Tolerate bad query result with bzlmod support #213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing the following errors with my previous change 😅 . Apparently bazel query can sometimes fail and as a result bazel-diff crashes due to NPE in such cases. Unfortunately I can't figured out another way to reliably get the path under
<bazel-cache/external/
without bazel query so this PR will just fallback to the old bazel external module path if bazel query failed.