Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle lifecyclestop() when connecting #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

changyujiang
Copy link

Hope to handle lifecyclestop() in Connecting state.

@changyujiang
Copy link
Author

Sscenario:
In demo app, I pointed echoService to an invalid address, scarlet keep trying to reconnect.

Issue:
When I logged out during WaitingToTry, websocket is closed and stopped retry. While I logged out during Connecting, the log_out event is not handled and websocket connection keeps failing and retrying.

We might need to handle lifecycleStop during Connecting state, or a more graceful way to solve it.

@ilyaklyukin
Copy link

Similar issue on 0.2.x branch, but there is no connection.kt class...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants