Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NodeXcodeTemplateV2 #610

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Introduce NodeXcodeTemplateV2 #610

merged 5 commits into from
Feb 22, 2024

Conversation

tinder-emanharoutunian
Copy link
Contributor

No description provided.

@tinder-emanharoutunian tinder-emanharoutunian changed the base branch from main to starting-branch-plus-rename February 6, 2024 23:56
@tinder-emanharoutunian tinder-emanharoutunian changed the base branch from starting-branch-plus-rename to use-permutations February 6, 2024 23:56
@tinder-emanharoutunian tinder-emanharoutunian marked this pull request as ready for review February 7, 2024 00:10
@tinder-emanharoutunian tinder-emanharoutunian self-assigned this Feb 7, 2024
@tinder-emanharoutunian tinder-emanharoutunian force-pushed the introduce-wizard-node-template branch from 2b3d0b7 to da89c98 Compare February 7, 2024 02:42
tinder-cfuller
tinder-cfuller reviewed Feb 8, 2024
View reviewed changes
@tinder-emanharoutunian tinder-emanharoutunian force-pushed the introduce-wizard-node-template branch from 0f113d4 to 14bb66f Compare February 8, 2024 19:29
@tinder-emanharoutunian tinder-emanharoutunian force-pushed the introduce-wizard-node-template branch from 14bb66f to cdb04f3 Compare February 8, 2024 22:00
@tinder-emanharoutunian tinder-emanharoutunian changed the title Introduce wizard node template Introduce NodeTemplateV2 Feb 8, 2024
@tinder-garricnahapetian tinder-garricnahapetian changed the title Introduce NodeTemplateV2 Introduce NodeXcodeTemplateV2 Feb 8, 2024
Base automatically changed from use-permutations to main February 21, 2024 20:14
@tinder-emanharoutunian tinder-emanharoutunian force-pushed the introduce-wizard-node-template branch from 9eb69a6 to 331e9a8 Compare February 21, 2024 22:24
tinder-cfuller
tinder-cfuller reviewed Feb 22, 2024
View reviewed changes
Sources/NodesGenerator/XcodeTemplates/NodeXcodeTemplateV2.swift Outdated
Comment on lines 17 to 36
Option(identifier: "productName",
name: "Node name:",
description: "The name of the new node.",
default: "MyFeatureV1")
Option(identifier: XcodeTemplateConstants.usePluginList,
name: "Created For Existing Plugin List",
description: "Whether the node is created for use in an existing plugin list.",
type: "checkbox",
default: "true")
Option(identifier: XcodeTemplateConstants.pluginListName,
name: "Existing Plugin List:",
description: "The name of an existing plugin list.",
default: "MyFeature",
requiredOptions: [XcodeTemplateConstants.usePluginList: ["true"]])
Option(identifier: "uiFramework",
name: "UI Framework:",
description: "The UI framework of the new node.",
type: "popup",
default: firstFramework.name,
values: uiFrameworks.map(\.framework).map(\.name))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🤩

@tinder-emanharoutunian tinder-emanharoutunian force-pushed the introduce-wizard-node-template branch from d5efb98 to c6536a3 Compare February 22, 2024 18:40
tinder-cfuller
tinder-cfuller approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@tinder-cfuller tinder-cfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sources/NodesGenerator/XcodeTemplates/NodeXcodeTemplateV2.swift
Comment on lines +17 to +36
Option(identifier: "productName",
name: "Node name:",
description: "The name of the new node.",
default: "MyFeatureV1")
Option(identifier: XcodeTemplateConstants.usePluginList,
name: "Created For Existing Plugin List",
description: "Whether the node is created for use in an existing plugin list.",
type: "checkbox",
default: "true")
Option(identifier: XcodeTemplateConstants.pluginListName,
name: "Existing Plugin List:",
description: "The name of an existing plugin list.",
requiredOptions: [XcodeTemplateConstants.usePluginList: ["true"]],
default: "MyFeature")
Option(identifier: "uiFramework",
name: "UI Framework:",
description: "The UI framework of the new node.",
type: "popup",
values: uiFrameworks.map(\.framework).map(\.name),
default: firstFramework.name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still beautiful! 🤩

@tinder-emanharoutunian tinder-emanharoutunian merged commit 413b5f3 into main Feb 22, 2024
6 checks passed
@tinder-emanharoutunian tinder-emanharoutunian deleted the introduce-wizard-node-template branch February 22, 2024 19:22
@tinder-emanharoutunian tinder-emanharoutunian added generator Generator and removed templates Templates labels Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinder-garricnahapetian tinder-garricnahapetian tinder-garricnahapetian left review comments

@tinder-cfuller tinder-cfuller tinder-cfuller approved these changes

Assignees
No one assigned
Labels
generator Generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinder-emanharoutunian @tinder-cfuller @tinder-garricnahapetian