Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce complexity of modal style #602

Merged
merged 6 commits into from
Feb 10, 2024
Merged

Reduce complexity of modal style #602

merged 6 commits into from
Feb 10, 2024

Conversation

tinder-cfuller
Copy link
Collaborator

@tinder-cfuller tinder-cfuller commented Jan 17, 2024 •
edited
Loading

  • Remove controlStatusBarAppearance property (aka modalPresentationCapturesStatusBarAppearance) since it only applies to non-fullscreen presentations
  • Remove allowInteractiveDismissal property (aka isModalInPresentation) so modal style "enforces modal behavior" by default since interactive dismissal requires a custom presentation method to be implemented by a view controller in order to set the necessary delegate and respond accordingly to the interactive dismissal and detach the Node
  • Remove underscore from withAdditionalConfiguration method along with deprecation language in comment
  • Custom modal presentation style is no longer supported out-of-the box and using .custom() sets modalPresentationStyle to .none and isModalInPresentation to true

@tinder-cfuller tinder-cfuller added the framework Framework label Jan 17, 2024
@tinder-cfuller tinder-cfuller marked this pull request as ready for review January 25, 2024 21:58
tinder-garricnahapetian
tinder-garricnahapetian approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@tinder-garricnahapetian tinder-garricnahapetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can all #available/@available be removed including from tests?

@tinder-cfuller tinder-cfuller merged commit 2c08383 into main Feb 10, 2024
6 checks passed
@tinder-cfuller tinder-cfuller deleted the modal-style branch February 10, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinder-garricnahapetian tinder-garricnahapetian tinder-garricnahapetian approved these changes

Assignees
No one assigned
Labels
framework Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinder-cfuller @tinder-garricnahapetian