Added the implementation logic to create Plugin tests alongside a plugin #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tests.stencil Co-authored-by: Christopher Fuller <[email protected]>
…Tests.stencil Co-authored-by: Christopher Fuller <[email protected]>
Tests/NodesXcodeTemplatesGeneratorTests/StencilRendererTests.swift
Outdated
Show resolved
Hide resolved
Tests/NodesXcodeTemplatesGeneratorTests/StencilRendererTests.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil
Tests/NodesXcodeTemplatesGeneratorTests/Support/TestFactories.swift
Outdated
Show resolved
Hide resolved
Tests/NodesXcodeTemplatesGeneratorTests/Support/TestFactories.swift
Outdated
Show resolved
Hide resolved
…swift Co-authored-by: Garric Nahapetian <[email protected]>
…swift Co-authored-by: Garric Nahapetian <[email protected]>
* Added a tests template for Plugin * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Christopher Fuller <[email protected]> * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Christopher Fuller <[email protected]> * Added override test * addressing comments * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Christopher Fuller <[email protected]> * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Garric Nahapetian <[email protected]> * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Christopher Fuller <[email protected]> * Update Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil Co-authored-by: Christopher Fuller <[email protected]> --------- Co-authored-by: Christopher Fuller <[email protected]> Co-authored-by: Garric Nahapetian <[email protected]>
Sources/NodesXcodeTemplatesGenerator/Resources/Stencils/PluginTests.stencil
Show resolved
Hide resolved
Sources/NodesXcodeTemplatesGenerator/XcodeTemplates/PluginNodeXcodeTemplate.swift
Outdated
Show resolved
Hide resolved
| @@ -21,13 +21,16 @@ internal struct PluginXcodeTemplate: XcodeTemplate { | |||
|
|
|||
| internal init(config: Config) { | |||
| let plugin: StencilTemplate = .plugin | |||
| stencils = [plugin] | |||
| let pluginTests: StencilTemplate = .pluginTests | |||
| stencils = config.isTestTemplatesGenerationEnabled ? [plugin, pluginTests] : [plugin] | |||
There was a problem hiding this comment.
Can this be done this way so plugin is only referenced one time?
Suggested change
| stencils = config.isTestTemplatesGenerationEnabled ? [plugin, pluginTests] : [plugin] | |
| stencils = [plugin] + config.isTestTemplatesGenerationEnabled ? [pluginTests] : [] |
There was a problem hiding this comment.
see above
Tests/NodesXcodeTemplatesGeneratorTests/StencilRendererTests.swift
Outdated
Show resolved
Hide resolved
Tests/NodesXcodeTemplatesGeneratorTests/StencilRendererTests.swift
Outdated
Show resolved
Hide resolved
|
Looking great, Sam. Please manually test these changes using the Quick Start. Please test with |
tinder-garricnahapetian
previously approved these changes
Jan 18, 2024
…Tests.stencil Co-authored-by: Garric Nahapetian <[email protected]>
…wift Co-authored-by: Christopher Fuller <[email protected]>
…wift Co-authored-by: Christopher Fuller <[email protected]>
…XcodeTemplate.swift Co-authored-by: Christopher Fuller <[email protected]>
tinder-cfuller
approved these changes
Jan 25, 2024
|
@tinder-garricnahapetian tested both implementation in a Quickstart. Looking good |
tinder-garricnahapetian
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the logic to create PluginTests.swift along side a plugin. We use the same boolean in config to toggle on and off the plugin tests.