Incorporate breaking changes from Timely's logging update (#558)

* Incorporate breaking changes from Timely's logging update TimelyDataflow/timely-dataflow#615 Signed-off-by: Moritz Hoffmann <[email protected]> * Back out of some changes Signed-off-by: Moritz Hoffmann <[email protected]> * Upgrade timely Signed-off-by: Moritz Hoffmann <[email protected]> * Fix compile errors Signed-off-by: Moritz Hoffmann <[email protected]> --------- Signed-off-by: Moritz Hoffmann <[email protected]>
TimelyDataflow · Jan 9, 2025 · 17a053b · 17a053b
1 parent c3871fb
commit 17a053b
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 22 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -48,7 +48,7 @@ timely = {workspace = true}
 columnar = "0.2"
 
 [workspace.dependencies]
-timely = { version = "0.15", default-features = false }
+timely = { version = "0.16", default-features = false }
 #timely = { path = "../timely-dataflow/timely/", default-features = false }
 
 [features]

diff --git a/examples/bfs.rs b/examples/bfs.rs
@@ -7,7 +7,7 @@ use differential_dataflow::input::Input;
 use differential_dataflow::Collection;
 use differential_dataflow::operators::*;
 use differential_dataflow::lattice::Lattice;
-use differential_dataflow::logging::DifferentialEvent;
+use differential_dataflow::logging::DifferentialEventBuilder;
 
 type Node = u32;
 type Edge = (Node, Node);
@@ -30,7 +30,7 @@ fn main() {
             if let Ok(stream) = ::std::net::TcpStream::connect(&addr) {
                 let writer = ::timely::dataflow::operators::capture::EventWriter::new(stream);
                 let mut logger = ::timely::logging::BatchLogger::new(writer);
-                worker.log_register().insert::<DifferentialEvent,_>("differential/arrange", move |time, data|
+                worker.log_register().insert::<DifferentialEventBuilder,_>("differential/arrange", move |time, data|
                     logger.publish_batch(time, data)
                 );
             }

diff --git a/examples/dynamic.rs b/examples/dynamic.rs
@@ -7,7 +7,7 @@ use differential_dataflow::input::Input;
 use differential_dataflow::Collection;
 use differential_dataflow::operators::*;
 use differential_dataflow::lattice::Lattice;
-use differential_dataflow::logging::DifferentialEvent;
+use differential_dataflow::logging::DifferentialEventBuilder;
 
 type Node = u32;
 type Edge = (Node, Node);
@@ -30,7 +30,7 @@ fn main() {
             if let Ok(stream) = ::std::net::TcpStream::connect(&addr) {
                 let writer = ::timely::dataflow::operators::capture::EventWriter::new(stream);
                 let mut logger = ::timely::logging::BatchLogger::new(writer);
-                worker.log_register().insert::<DifferentialEvent,_>("differential/arrange", move |time, data|
+                worker.log_register().insert::<DifferentialEventBuilder,_>("differential/arrange", move |time, data|
                     logger.publish_batch(time, data)
                 );
             }

diff --git a/interactive/src/manager.rs b/interactive/src/manager.rs
@@ -7,7 +7,7 @@ use std::hash::Hash;
 use timely::dataflow::ProbeHandle;
 use timely::communication::Allocate;
 use timely::worker::Worker;
-use timely::logging::TimelyEvent;
+use timely::logging::TimelyEventBuilder;
 
 // use timely::dataflow::operators::capture::event::EventIterator;
 
@@ -16,7 +16,7 @@ use differential_dataflow::trace::implementations::{KeySpine, ValSpine};
 use differential_dataflow::operators::arrange::TraceAgent;
 use differential_dataflow::input::InputSession;
 
-use differential_dataflow::logging::DifferentialEvent;
+use differential_dataflow::logging::DifferentialEventBuilder;
 
 use crate::{Time, Diff, Plan, Datum};
 
@@ -87,11 +87,11 @@ impl<V: ExchangeData+Datum> Manager<V>
         // Deregister loggers, so that the logging dataflows can shut down.
         worker
             .log_register()
-            .insert::<TimelyEvent,_>("timely", move |_time, _data| { });
+            .insert::<TimelyEventBuilder,_>("timely", move |_time, _data| { });
 
         worker
             .log_register()
-            .insert::<DifferentialEvent,_>("differential/arrange", move |_time, _data| { });
+            .insert::<DifferentialEventBuilder,_>("differential/arrange", move |_time, _data| { });
     }
 
     /// Inserts a new input session by name.
@@ -226,4 +226,4 @@ impl<V: ExchangeData+Hash+Datum> TraceManager<V> {
             .insert(keys.to_vec(), handle.clone());
     }
 
-}
+}
diff --git a/src/logging.rs b/src/logging.rs
@@ -3,8 +3,11 @@
 use columnar::Columnar;
 use serde::{Deserialize, Serialize};
 
+/// Container builder for differential log events.
+pub type DifferentialEventBuilder = timely::container::CapacityContainerBuilder<Vec<(std::time::Duration, DifferentialEvent)>>;
+
 /// Logger for differential dataflow events.
-pub type Logger = ::timely::logging::Logger<DifferentialEvent>;
+pub type Logger = ::timely::logging_core::TypedLogger<DifferentialEventBuilder, DifferentialEvent>;
 
 /// Enables logging of differential dataflow events.
 pub fn enable<A, W>(worker: &mut timely::worker::Worker<A>, writer: W) -> Option<Box<dyn std::any::Any+'static>>
@@ -16,7 +19,7 @@ where
     let mut logger = ::timely::logging::BatchLogger::new(writer);
     worker
         .log_register()
-        .insert::<DifferentialEvent,_>("differential/arrange", move |time, data| logger.publish_batch(time, data))
+        .insert::<DifferentialEventBuilder,_>("differential/arrange", move |time, data| logger.publish_batch(time, data))
 }
 
 /// Possible different differential events.

diff --git a/src/operators/arrange/arrangement.rs b/src/operators/arrange/arrangement.rs
@@ -437,7 +437,7 @@ where
         // Acquire a logger for arrange events.
         let logger = {
             let register = scope.log_register();
-            register.get::<crate::logging::DifferentialEvent>("differential/arrange")
+            register.get::<crate::logging::DifferentialEventBuilder>("differential/arrange").map(Into::into)
         };
 
         // Where we will deposit received updates, and from which we extract batches.

diff --git a/src/operators/arrange/upsert.rs b/src/operators/arrange/upsert.rs
@@ -156,7 +156,7 @@ where
             let logger = {
                 let scope = stream.scope();
                 let register = scope.log_register();
-                register.get::<crate::logging::DifferentialEvent>("differential/arrange")
+                register.get::<crate::logging::DifferentialEventBuilder>("differential/arrange").map(Into::into)
             };
 
             // Tracks the lower envelope of times in `priority_queue`.

diff --git a/src/operators/reduce.rs b/src/operators/reduce.rs
@@ -336,7 +336,7 @@ where
             let logger = {
                 let scope = trace.stream.scope();
                 let register = scope.log_register();
-                register.get::<crate::logging::DifferentialEvent>("differential/arrange")
+                register.get::<crate::logging::DifferentialEventBuilder>("differential/arrange").map(Into::into)
             };
 
             let activator = Some(trace.stream.scope().activator_for(operator_info.address.clone()));

diff --git a/src/trace/implementations/merge_batcher.rs b/src/trace/implementations/merge_batcher.rs
@@ -12,13 +12,12 @@
 
 use std::marker::PhantomData;
 
-use timely::logging_core::Logger;
 use timely::progress::frontier::AntichainRef;
 use timely::progress::{frontier::Antichain, Timestamp};
 use timely::Container;
 use timely::container::{ContainerBuilder, PushInto};
 
-use crate::logging::{BatcherEvent, DifferentialEvent};
+use crate::logging::{BatcherEvent, Logger};
 use crate::trace::{Batcher, Builder, Description};
 
 /// Creates batches from containers of unordered tuples.
@@ -41,7 +40,7 @@ pub struct MergeBatcher<Input, C, M: Merger> {
     /// The lower-bound frontier of the data, after the last call to seal.
     frontier: Antichain<M::Time>,
     /// Logger for size accounting.
-    logger: Option<Logger<DifferentialEvent>>,
+    logger: Option<Logger>,
     /// Timely operator ID.
     operator_id: usize,
     /// The `Input` type needs to be called out as the type of container accepted, but it is not otherwise present.
@@ -58,7 +57,7 @@ where
     type Time = M::Time;
     type Output = M::Chunk;
 
-    fn new(logger: Option<Logger<DifferentialEvent>>, operator_id: usize) -> Self {
+    fn new(logger: Option<Logger>, operator_id: usize) -> Self {
         Self {
             logger,
             operator_id,

diff --git a/src/trace/mod.rs b/src/trace/mod.rs
@@ -12,11 +12,10 @@ pub mod description;
 pub mod implementations;
 pub mod wrappers;
 
-use timely::logging_core::Logger;
 use timely::progress::{Antichain, frontier::AntichainRef};
 use timely::progress::Timestamp;
 
-use crate::logging::DifferentialEvent;
+use crate::logging::Logger;
 use crate::trace::cursor::IntoOwned;
 use crate::difference::Semigroup;
 use crate::lattice::Lattice;
@@ -309,7 +308,7 @@ pub trait Batcher {
     /// Times at which batches are formed.
     type Time: Timestamp;
     /// Allocates a new empty batcher.
-    fn new(logger: Option<Logger<DifferentialEvent>>, operator_id: usize) -> Self;
+    fn new(logger: Option<Logger>, operator_id: usize) -> Self;
     /// Adds an unordered container of elements to the batcher.
     fn push_container(&mut self, batch: &mut Self::Input);
     /// Returns all updates not greater or equal to an element of `upper`.