-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Input: Add type conversion to float and warning #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test cases for this change?
Should be good now. I implemented and ran the test case and made it more general per your suggestion. Apologies, I'm still kinda new to open-source contributions so had some trouble there... :). Also, I'm using the "Black formatter" so there was some automated formatting done as you'll see. Let me know if I need to do anything else. |
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 89.84% 89.87% +0.02%
==========================================
Files 53 53
Lines 2078 2083 +5
==========================================
+ Hits 1867 1872 +5
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Using Black is a good idea. I think, I will add Black to the project and follow-up with some more test cases. @B-Deforce thank you for your contribution! |
Resolves #30