Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Input: Add type conversion to float and warning #31

Merged
merged 4 commits into from
Jul 16, 2023
Merged

Custom Input: Add type conversion to float and warning #31

merged 4 commits into from
Jul 16, 2023

Conversation

B-Deforce
Copy link
Contributor

@B-Deforce B-Deforce commented Jul 14, 2023

Resolves #30

Copy link
Member

@CodeLionX CodeLionX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test cases for this change?

gutenTAG/base_oscillations/custom_input.py Outdated Show resolved Hide resolved
@CodeLionX CodeLionX added 🐛 bug(-fix) Something isn't working / was fixed 🏅 high MoSCoW: Must-have comp: GutenTAG (general) labels Jul 14, 2023
@CodeLionX CodeLionX changed the title Added auto conversion and warning for integer input data. Resolves #30 Custom Input: Add type conversion to float and warning Jul 14, 2023
@B-Deforce
Copy link
Contributor Author

B-Deforce commented Jul 14, 2023

Should be good now. I implemented and ran the test case and made it more general per your suggestion. Apologies, I'm still kinda new to open-source contributions so had some trouble there... :). Also, I'm using the "Black formatter" so there was some automated formatting done as you'll see.

Let me know if I need to do anything else.

@B-Deforce B-Deforce requested a review from CodeLionX July 15, 2023 13:30
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #31 (3df9c6b) into main (484d064) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   89.84%   89.87%   +0.02%     
==========================================
  Files          53       53              
  Lines        2078     2083       +5     
==========================================
+ Hits         1867     1872       +5     
  Misses        211      211              
Flag Coverage Δ
unittests 89.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gutenTAG/base_oscillations/custom_input.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CodeLionX
Copy link
Member

Using Black is a good idea.

I think, I will add Black to the project and follow-up with some more test cases.

@B-Deforce thank you for your contribution!

@CodeLionX CodeLionX merged commit 6834ec8 into TimeEval:main Jul 16, 2023
5 checks passed
@B-Deforce B-Deforce deleted the patch-1 branch July 17, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug(-fix) Something isn't working / was fixed comp: GutenTAG (general) 🏅 high MoSCoW: Must-have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type Mismatch Error When Using Integer Data with Custom Input
2 participants