Improved font handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Closes #5.
Font handling in Bevy is quite annoying in general, as you have to deal with individual font faces instead of font families and a given style.
For BBCode this is particularly annoying, as for each combination of bold, italic, regular you have to load a font separately and configure it.
Solution
This PR adds a new
FontPluginwhich is automatically included byBbcodePlugin.You now provide an asset path to a font folder when constructing the plugin.
The fonts in that folder are then loaded automatically and used to obtain the individual font handles.
Then in
BbcodeSettingsyou only need to specify the font family you want to use and it all happens automatically!