This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Make trait functions immutable #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the traits to be implemented on immutable references. Internal mutability can still be achieved through Cell or RefCell
6 tasks
|
I fixed the formatting. If you are okay with the changes, I'll squash the two commits. |
Wodann
force-pushed
the
feature/immutable-ref
branch
from
f3c6909 to
e639581
Compare
Wodann
force-pushed
the
feature/immutable-ref
branch
from
e639581 to
bcc633e
Compare
|
Thanks for the pull request and sorry I haven't been able to comment yet. I try to stick to Let's wait and see how the discussion develops in rust-gamedev/wg#70. |
This was referenced Jan 17, 2020
Closed
|
Solved by issue #37. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the traits to be implemented on immutable references, which is necessary whenever we have non-static instance of an allocator. Internal mutability can still be achieved through
CellorRefCell.I wrote a bump allocator that requires this change.