Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option "include_basedir" to add additional binary module files #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aheissenberger
Copy link

use case:
I have an folder "./node_modules_lambda" which is listed in ".npmignore" and contains "./node_modules_lambda/node_modules/fibers/bin/linux-x64-v8-3.14/fibers.node" which is the binary specific for the was lambda environment.

lambda_package: {
        default: {
            options: {
                include_files: [  './node_modules/fibers/bin/linux-x64-v8-3.14/**/*' ],
                include_basedir: './node_modules_lambda'
         }
     }
 },

@Tim-B
Copy link
Owner

Tim-B commented Jan 23, 2016

Hi Andreas, thanks for the pull request!

Could you help me understand your use case a little more. Is it that your lambda function is in the root directory, but your lambda package.json and node_modules is in a subdirectory?

Is there a reason you don't want to put it all in a subdirectory and use package_folder?

Also, it looks like some tests are failing. Is that due to the change or are they just flakey?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants