-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force grab/ungrab keyboard+mouse with Right Ctrl key #1906
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion!
Like the pointer lock API, we'd rather avoid pestering the user with this. We already have support for the pointer warp extension. And there is a relative mouse movement extension from QEMU that we could start supporting. Those would allow a more natural and automatic user experience.
Have you had a look at those?
I have no experience with the VNC protocol nor its extensions. |
7c36c88
to
b4971c8
Compare
The test case you have seems to work fine with the existing support in TigerVNC for relative mouse movements. So I think I misunderstood what this PR actually changes. The focus is rather to allow grabs in windowed mode. The big problem with that is adding more key bindings means more risk of conflict with what applications need. Have you looked at the existing discussion in #102? And the work in progress in #1375? The proposed plan there tries to minimize the conflict, and provides a way out in case a conflict still arises. |
Force grab/ungrab keyboard+mouse with Right Ctrl key,
Allows for control integration similar to what VirtualBox does.
Solves pointer movement glitches with applications that require grabbing the mouse internally
(like modern web browsers using the Pointer Lock API).
Test:
Without this patch the above website works only in TigerVNC viewer's fullscreen mode.