Skip to content

Commit

Permalink
Avoid fetching details of disabled pointer
Browse files Browse the repository at this point in the history
Certain versions of the xserver code will crash if you access the
details of a disabled pointer. The details are also not up to date when
it is disabled, so it is likely concepually wrong to ignore it at this
point anyway.

Issue originally discovered and diagnosed by Mark Mielke.
  • Loading branch information
CendioOssman committed Jan 14, 2025
1 parent fac3d80 commit ba73536
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion unix/xserver/hw/vnc/vncInput.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ void vncPointerMove(int x, int y)

void vncGetPointerPos(int *x, int *y)
{
if (vncPointerDev != NULL) {
if ((vncPointerDev != NULL) && (vncPointerDev->public.on)) {
ScreenPtr ptrScreen;

miPointerGetPosition(vncPointerDev, &cursorPosX, &cursorPosY);
Expand Down

0 comments on commit ba73536

Please sign in to comment.