Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flags in language plugins #8837

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

Leilei332
Copy link
Contributor

As is discussed in this comment

A related point is that my understanding is that it is not recommended to use flags to represent languages (see this article for an example of the arguments against the practice). I wonder if we should change to using the ISO language codes in the switch (eg "en-GB")

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit cd322f8
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/6780dcd5e6e928000882c131
😎 Deploy Preview https://deploy-preview-8837--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jermolene
Copy link
Member

Thanks @Leilei332 this is definitely worth doing. I've been aware of the issues with using flags for a long time and it is about time we fixed it.

I pushed some updates to get things building and start to figure out the dependencies that need adjustment. I've also added a generic "language" icon for use in the page control button.

I think some more testing is needed but this feels quite close to being mergeable.

@Leilei332 Leilei332 marked this pull request as ready for review December 22, 2024 00:02
@Leilei332 Leilei332 changed the title [IDEA] Remove flags in language plugins Remove flags in language plugins Jan 5, 2025
@Jermolene
Copy link
Member

Thanks @Leilei332 do you think this is ready to merge?

@Leilei332
Copy link
Contributor Author

Leilei332 commented Jan 9, 2025

I think it is ready to merge this PR now (after the temporary setting is removed).

@pmario
Copy link
Member

pmario commented Jan 9, 2025

I am not happy, that the flags are removed and gone. From my point of view they should be moved into a core plugin, with the possibility to load them and recreate the current behaviour.

I am OK that tiddlywiki-com tries to be free of political sentiment according to flags. I am not OK, that it is handled that way, by forcing everyone to remove flags from their wikis.

@Leilei332
Copy link
Contributor Author

Although flags do add colors to language plugins, I think we had better be practical. The language plugins are used to translate tiddlywiki, not to display a flag. IMO removing flags does more good than harm (Since we already have some controversal ones).

From my point of view they should be moved into a core plugin, with the possibility to load them and recreate the current behaviour.

I don't think it is necessary. For those who want to display a flag in their wiki, they can import the SVG image from wikipedia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants