-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour handling improvements #8702
base: master
Are you sure you want to change the base?
Conversation
The replacement library from https://colorjs.io/ is much, much larger but I think we can develop a custom build that uses treeshaking to whittle the code down to the bits that we need. @linonetwo does that sound feasible? I intend the explore further improvements but I wanted to start by establishing a library that can do modern P3 and OKLCH colour calculations.
Really just syntactic sugar for the wikify widget
Using the new wikify operator. Currently has a bug whereby redirected colours (like "tiddler-background") do not work. Direct colours like "background" do work. Note the hacks needed to makeFakeWidgetWithVariables work
Confirmed: Jermolene has already signed the Contributor License Agreement (see contributing.md) |
Is there a demo to test colour handling improvement? |
Hi @kookma I've posted a preview to tiddlyhost |
To avoid confusion with existing usage of "palette editor"
Now that we're dealing with the schemes during the import process it is no longer necessary for the compilation process to worry about it.
Instead, we'll special case transforming `<<colour X>>` into `[function[colour],[x]]` Makes everything much easier and avoids all the kerfuffle of not being able to mix palettes
More robust because previously we couldn't cope with indirect palette entries in these situations
Takes the opportunity to simplify things now that we don't have to worry about wikified palettes
These are the generic tests that should be applied to every palette
The map filter run prefix is often used as a way to move a computed value in the input list into a variable so that it can be used as a parameter of a filter operator. The apply filter run prefix extends this idea to make the input list available as variables $1, $2 etc. Unlike the map prefix, the apply filter run is only evaluated once.
It shouldn't be enabled by default, either, but we'll come back to that
Was just for testing
Thanks @springerspandrel
That should be fixed now.
The previews now show sidebar tabs in the appropriate colours.
That should be fixed now.
Both suggestions are now implemented.
That should be fixed now.
A block of code is an excellent idea.
I have included an alert in the latest update, but the challenge is that it obscures the title of the first tiddler. Perhaps previews need multiple pages to show things like alerts, notifications and modals. |
@@ -0,0 +1,94 @@ | |||
title: $:/PaletteEditor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, this file hasn't been changed (yet), it is just moved from $:/PaletteManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to add that this file needs substantial revision so I will add indentation when I do that.
Introduction
This PR brings several new features for end users:
There are also new capabilities for palette authors:
To make all of these new features possible, this PR also includes some useful new general purpose mechanisms and features:
$:/info/...
tiddlerchangecount
filter operator:apply
filter run prefixTry the Demo
A preview build is available at https://deploy-preview-8702--tiddlywiki-previews.netlify.app/
Changes to Palettes
Palette entries are now defined as filters that must be evaluated, rather than wikitext that must be wikified.
This makes it possible to create palettes that reference and modify other colours. For example:
Retrospectively re-interpreting palettes entries as filters would normally mean that
<<colour background>>
would no longer work. Instead these entries are automatically converted to the updated form[function[colour],[background]]
.Palette Compilation
The key idea underpinning these changes is a fundamental change to the way that TiddlyWiki handles palettes. At the moment, palette entries are named items that can contain either a CSS colour string, a CSS colour token like "inherit", or can use the
<<colour>>
macro to reference another colour palette entry. Thus, palette entries have to be wikified before they can be used. This has turned out to be very limiting and doesn't provide a viable path to the complex colour manipulations shown above. Switching to filters might make things worse, by encouraging authors to use complex expressions within palettes.The fix is compiled palettes: at the point of switching to a new palette, the colours within it are "compiled" to raw CSS colour values (typically but not necessarily in
#rrggbbaa
format). This allows palette entries to be used directly, without the requirement to wikify them.The static palette is created in a new system tiddler
$:/temp/palette-colours
by an action procedure that is invoked at startup and when switching to a new palette.There should not be any backwards compatibility issues because the use of background actions means that any code that changes
$:/palette
will automatically trigger the recompilation of the palette.This change also allows us to change the
<<colour>>
procedure to be a function, which allows it to be used as the value for a style attribute:Automatic Palette Readability Tests
Palettes can opt to include readability tests as special palette entries. The results of these tests are shown at the bottom of the palette chooser. For example:
The test framework looks for palette entries starting with a question mark and runs the associated filters. The filter should return nothing if there are no errors, or a textual error message if the conditions are violated. Sample output:
Colour Manipulation
We need a colour manipulation library that can calculate variants of colours. Only color.js met the requirements of being able to work with P3 colours and the OKLCH colour space. It also includes a CSS colour string parser which can replace the simple one that TiddlyWiki has always incorporated.
Media Query Tracker
The CSS media query tracker allows a media query to be bound to an info tiddler so that the current state of the query is reflected in the value of the tiddler. The value is updated dynamically.
The use of the info mechanism for the CSS media query tracker means that these tiddlers are dynamically created as shadow tiddlers within the
$:/temp/info
plugin, and so do not appear in tiddler lists.The mechanism is used to implement the existing dark mode tiddler with the following configuration:
Note the use of
info-tiddler-alt
to specify a redundant secondary info tiddler. This is used by the dark mode tracker to maintain compatibility while changing the info tiddler title for consistency.Background Actions
The new background actions mechanism allows action strings to be invoked automatically in the background whenever the results of a filter change.
The preview includes a demonstration background action that displays an alert with a list of tiddlers in the story river whenever the story river changes:
apply
Filter Run PrefixAn experimental new filter run prefix that makes it possible to use computed values as variables within a filter run. For example:
Backwards Compatibility
$:/config/DefaultColourMappings/
now only supports CSS colours, and not indirections via<<colour X>>
or[function[colour],[X]]
References
Progress
changecount
operatorcolour-interpolate
operatorcolour-lighten
operatorcolour-darken
operatorcolour-get-oklch
operatorcolour-set-oklch
operatorcolour-contrast
operatorcolour-best-contrast
operator