Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra p tag in colour-picker #8605

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Leilei332
Copy link
Contributor

@Leilei332 Leilei332 commented Sep 16, 2024

The following code didn't display correctly in tiddlywiki, the color circle is displayed lower:

\procedure color-picker-actions()
<$action-setfield $tiddler=<<currentTiddler>> color=<<colour-picker-value>>/>
\end

<$transclude $variable="colour-picker" actions=<<color-picker-actions>>/>

I found that the p tag may be created when the actions parameter isn't empty. After I removed two newline the problem was solved.

图片

Copy link

stackblitz bot commented Sep 16, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Thanks @Leilei332

@Jermolene Jermolene merged commit 0f4d6e4 into TiddlyWiki:master Sep 16, 2024
4 checks passed
@Leilei332 Leilei332 deleted the fix-color-picker-extra-p-tag branch October 4, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants