Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a settings page for markdown plugin #8585

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

Leilei332
Copy link
Contributor

@Leilei332 Leilei332 commented Sep 6, 2024

The table in $:/plugins/tiddlywiki/markdown/config isn't convenient to edit configuations for markdown plugin, and it also causes the page to overflow in mobile devices.

This PR add a settings page for markdown plugin under the "Settings" tab in control panel, which is convenient to edit settings. It also removes the overflowed table in $:/plugins/tiddlywiki/markdown/config.

Copy link

stackblitz bot commented Sep 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Sep 6, 2024

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member

pmario commented Sep 6, 2024

It looks good. But I would move the "Quotes replacement" section below the "Typographer" toggle. Quotes depends on Typo- So they should be together

image

@pmario
Copy link
Member

pmario commented Sep 6, 2024

There should also be a link to eg:

For more information see the plugin "readme and config" tab -- (Using TW wiki-links )

The transclusion to $:/plugins/tiddlywiki/markdown/settings in config
tab is removed to avoid confusion
@pmario
Copy link
Member

pmario commented Sep 8, 2024

If we have settings. Imo config is redundant

@Leilei332
Copy link
Contributor Author

If we have settings. Imo config is redundant

IMO the contents in the config tab can be moved to the readme tab.

@Jermolene
Copy link
Member

IMO the contents in the config tab can be moved to the readme tab.

I think that's a good idea @Leilei332

@Jermolene
Copy link
Member

Hi @Leilei332 I'm going to merge this now, we can always come back to moving the config tab content into the readme tab.

@Jermolene Jermolene merged commit 3434884 into TiddlyWiki:master Sep 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants