Update PageControls buttons to use v5.3.2 syntax

[Leilei332]

It is strange that PageControls buttons uses list widget to display text and icons.

This PR rewrites PageControls buttons and actions to use newer syntax. Including:

• Replace some list widget with conditonal shortcut syntax
• Replace macrocall widget with transclude widget
• Replace some macros with procedures and Substituted Attribute Values
• Replace vars widget and some set widget with let widget

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[github-actions]

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

[Jermolene]

Thanks @Leilei332 I think this is a good idea.

[pmario]

IMO there are some buttons missing: [tag[tags: $:/tags/PageControls]] shows all of them or the right sidebar -> Tools tab

[Jermolene]

Thanks @Leilei332 these are worthwhile improvements. Just one small point below

[Jermolene]

Here I do prefer readability over space. So I would prefer <% if [[filter]] %> -- I think the extras spaces here are much more readable. Especially for <%elseif%><%else%> the differences are hard to see

I recognise that you disagree but we have to decide on a single approach and use it consistently. I don't think that the whitespace makes things more readable, rather the opposite: it means that the brain has to process the two parts separately, rather than seeing them as a single symbol.

The other consideration is consistency with the way that we write widgets: we do not write <$ list filter="">.

A further but minor point is that omitting the whitespace will lead to smaller tiddlers.

I will push an update to make things consistent on that basis.

[pmario]

In the end it is your decision. So I'll change my code in pending PRs accordingly.

[Jermolene]

In the end it is your decision. So I'll change my code in pending PRs accordingly.

It is no fun deciding these things, and I try to take other peoples views into account, but sometimes we're face with these binary choices where there is no answer that is going to please everyone.

[kookma]

This PR rewrites PageControls buttons and actions to use newer syntax. Including:

The code is much readable now! Thank you.

[Jermolene]

Thanks @Leilei332 @pmario – is this ready to merge now?

[saqimtiaz]

@Jermolene we should make a considered decision as to when we want to prefix the names of functions with tf..

I can understand the rationale behind doing so for global functions or those that can pollute the variable namespace for user content, however is it really necessary in the context of page control buttons? I find that the prefix reduces the legibility and expressiveness of the code.

[pmario]

I did start a "discussion" some time ago and did reply there: #7955 (comment)

[Jermolene]

Thanks @Leilei332 I am inclined to agree with @saqimtiaz that we should only use the tf- prefix for globally visible functions. Could you kindly amend the PR? Many thanks.

[Jermolene]

Thank you @Leilei332