Fix float right overflow #8557
Merged
Fix float right overflow #8557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So tc-subtitle needs a clearfix to contains float:right
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
|
@Jermolene -- clearfixes should not alter the general UI. The only "catch" float:rights and contain them. So it should be pretty safe without any side effects. |
|
The PR now only contains "clearfix" changes |
Jermolene
reviewed
Sep 6, 2024
|
@Jermolene -- See the last 3 commits. It should be ready for merge now. |
|
Thank you @pmario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #8556
tc-tiddler-title,tc-subtitle,tc-tags-wrapperandtc-tiddler-bodyfor the different core templatescore/ui/EditTemplate/controls.tid also covers the "title" into a SPAN element to make it styleable.<span tc-tiddler-title-draft><$view field="title"/></span>