Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make overflowed content scrollable #8524

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Leilei332
Copy link
Contributor

This PR closes #8523.

Add overflow-x: auto to tc-tiddler-body and tc-tab-content to make overflowed content scrollable, so that overflowed content can be handled correctly.

Copy link

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@Jermolene
Copy link
Member

Thanks @Leilei332 – I wonder if this solution might lead to scrollable areas nested within other scrollable areas? If so, I'd be concerned that it will be hard for us to assess usability across all the relevant browsers. For example, browsers configured to always show visible scrollbars might be confusing (which is already an issue with the sidebar implementation).

@Jermolene
Copy link
Member

Hi @Leilei332 I think we should merge this. While I have reservations about the fix, it is a lot less broken than the current behaviour. I'd be grateful if you could resolve the merge conflict. Many thanks.

@Leilei332
Copy link
Contributor Author

@Leilei332 -- It seems the latest changes have completely removed the tabs from all CSS rules. Is that intended?

I have fixed it. This is because I typed < in vim by mistake.

@Jermolene
Copy link
Member

Thanks @Leilei332

@Jermolene Jermolene merged commit d7b00a6 into TiddlyWiki:master Sep 10, 2024
3 checks passed
@Leilei332
Copy link
Contributor Author

Leilei332 commented Sep 10, 2024

Looks like tc-scary-warning is not compatible with this PR:

Screenshot_20240910-221414.jpg

Before:

Screenshot_20240910-221624.jpg

@Jermolene
Copy link
Member

Ouch thanks @Leilei332 do you have time to work on a fix?

Jermolene added a commit that referenced this pull request Sep 10, 2024
@Jermolene
Copy link
Member

Looks like tc-scary-warning is not compatible with this PR:

On further investigation, I am inclined to think that we need to revert this PR. The ability to place content in the margins of tiddlers is important for some layouts, and so I think introducing a new scrolling context is too much of a break in backwards compatibility.

The revert is in 695e2ee

I'd welcome further exploration of a better fix.

@Leilei332
Copy link
Contributor Author

Looks like overflow often occurs in elements like table and table of content macros. I think it may be better to only make them scrollable on overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Better handling for overflowed content
2 participants