-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make overflowed content scrollable #8524
Conversation
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
Thanks @Leilei332 – I wonder if this solution might lead to scrollable areas nested within other scrollable areas? If so, I'd be concerned that it will be hard for us to assess usability across all the relevant browsers. For example, browsers configured to always show visible scrollbars might be confusing (which is already an issue with the sidebar implementation). |
Hi @Leilei332 I think we should merge this. While I have reservations about the fix, it is a lot less broken than the current behaviour. I'd be grateful if you could resolve the merge conflict. Many thanks. |
I have fixed it. This is because I typed |
Thanks @Leilei332 |
Ouch thanks @Leilei332 do you have time to work on a fix? |
This reverts commit d7b00a6.
On further investigation, I am inclined to think that we need to revert this PR. The ability to place content in the margins of tiddlers is important for some layouts, and so I think introducing a new scrolling context is too much of a break in backwards compatibility. The revert is in 695e2ee I'd welcome further exploration of a better fix. |
Looks like overflow often occurs in elements like table and table of content macros. I think it may be better to only make them scrollable on overflow. |
This PR closes #8523.
Add
overflow-x: auto
totc-tiddler-body
andtc-tab-content
to make overflowed content scrollable, so that overflowed content can be handled correctly.