Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROOF OF CONCEPT] Playwright report in pr #7824

Closed

Conversation

EvidentlyCube
Copy link
Contributor

This is a draft PR to attempt to add posting playwright build reports into the PR.

References:

It's not posted as a draft to make sure all actions run. I'll be actively working on this so feel free to ignore this PR until I remove [PROOF OF CONCEPT] from the title.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Nov 29, 2023 9:53pm

@Jermolene
Copy link
Member

Thank you @EvidentlyCube good luck with this, much appreciated.

@EvidentlyCube
Copy link
Contributor Author

I am closing this PR. I was unable to make it work and ran out of ideas to try so I won't be able to put anymore work into this.

@Jermolene
Copy link
Member

Thanks for all your work @EvidentlyCube, much appreciated. Hopefully your commits in this PR might help someone in the future.

@EvidentlyCube
Copy link
Contributor Author

The main obstacle I've encountered is that it appears that there are two contexts in which github actions run in response to pull requests. One is on.pull_request which, simplifying, runs in the context of the fork and on.pull_request_target which runs in the context of the target repository. The former context doesn't allow posting comments in PR and the latter context is somehow protected - the jobs wouldn't run when a new commit was pushed into the PR branch.

There must be some trick to get it all working because it feels like something doable but no luck for me :).

@Jermolene
Copy link
Member

Thank you @EvidentlyCube that is interesting. It appears that Vercel (and presumably other CI integrations) do manage to do the same thing, so it must be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants