Skip to content

Commit

Permalink
chore: use consola over console
Browse files Browse the repository at this point in the history
  • Loading branch information
kevinmarrec committed Aug 15, 2019
1 parent cd0195e commit 38815f1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 2 additions & 1 deletion lib/module.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const path = require('path')
const fs = require('fs')
const consola = require('consola')
const merge = require('deepmerge')

const defaults = {
Expand Down Expand Up @@ -81,7 +82,7 @@ module.exports = function (moduleOptions) {
} else {
const wrapValue = val => typeof val === 'string' ? `\`'${val}'\`` : `\`${val}\``
const supportedValues = [...Object.keys(cdn), false].map(wrapValue)
console.warn(`[@nuxtjs/vuetify] Value ${wrapValue(defaultIconPreset)} for \`defaultAssets.icons\` option is not supported (Supported values : ${supportedValues.join(', ')})`)
consola.warn(`[@nuxtjs/vuetify] Value ${wrapValue(defaultIconPreset)} for \`defaultAssets.icons\` option is not supported (Supported values : ${supportedValues.join(', ')})`)
}
}

Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"types/*.d.ts"
],
"dependencies": {
"consola": "^2.10.1",
"deepmerge": "^4.0.0",
"fibers": "^4.0.1",
"sass": "^1.22.9",
Expand Down
7 changes: 4 additions & 3 deletions test/module.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
jest.setTimeout(60000)

const consola = require('consola')
const { Nuxt, Builder } = require('nuxt-edge')

const config = require('./fixture/nuxt.config')
Expand Down Expand Up @@ -50,11 +51,11 @@ describe('disable all default assets', () => {
})

describe('set wrong value to defaultAssets.icons', () => {
let consoleWarnSpy
let consolaWarnSpy
let nuxt

beforeAll(async () => {
consoleWarnSpy = jest.spyOn(console, 'warn')
consolaWarnSpy = jest.spyOn(consola, 'warn')
nuxt = new Nuxt({
...config,
vuetify: {
Expand All @@ -72,7 +73,7 @@ describe('set wrong value to defaultAssets.icons', () => {
})

test('should have warned user', () => {
expect(consoleWarnSpy).toHaveBeenCalledWith("[@nuxtjs/vuetify] Value `'wrong'` for `defaultAssets.icons` option is not supported (Supported values : `'mdi'`, `'md'`, `'fa'`, `'fa4'`, `false`)")
expect(consolaWarnSpy).toHaveBeenCalledWith("[@nuxtjs/vuetify] Value `'wrong'` for `defaultAssets.icons` option is not supported (Supported values : `'mdi'`, `'md'`, `'fa'`, `'fa4'`, `false`)")
})
})

Expand Down

0 comments on commit 38815f1

Please sign in to comment.