1.0.1 bug fix for preprocessing extraction #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, extraction could in certain circumstances errouneously extract file contents belonging to included files having similar filenames to the target of extraction in preprocessor output line markers. Solved by using Ruby’s File.expand_path() that ensures full absolute filepaths are considered in completion for matches. Expanded and clarified comment documentation including link to relevant GCC preprocessor documentation. Added test cases to clarify desired content extraction and content ignore behavior.
Opens and processes the preprocessed file output but provides the original source filepath to the extraction routine for proper filepath matching
mvandervoord
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best solution was both the simplest and most robust — comparing absolute file paths when deciding which sections of a preprocess file to extract.
All tests pass and new prerelease is a avaialble.