Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module updates #3

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Module updates #3

merged 6 commits into from
Oct 27, 2023

Conversation

Thomas-George-T
Copy link
Owner

Changelog

  • Moved functions from datapipelines.py to separate modules
  • Updated tests for download_data.py
  • Updated tests for unzip_data.py
  • Integrated above functions into datapipelines.py
  • Added fake zip data/bad.zip for test mocking
  • Added init-hook to pylintrc
  • Added requests-mock to requirements.txt

@Thomas-George-T Thomas-George-T self-assigned this Oct 26, 2023
@Thomas-George-T Thomas-George-T added the enhancement New feature or request label Oct 26, 2023
@AshyScripts
Copy link
Collaborator

It all looks good to me :)

@AshyScripts AshyScripts merged commit 918ec0e into main Oct 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshyScripts AshyScripts AshyScripts approved these changes

@baridamm baridamm Awaiting requested review from baridamm

Assignees

@Thomas-George-T Thomas-George-T

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas-George-T @AshyScripts