Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add created type PullRequestReviewEvent #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add created type PullRequestReviewEvent #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/com/thirtydegreesray/openhub/mvp/model/EventPayload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public enum PullRequestReviewCommentEventActionType{
}

public enum PullRequestReviewEventActionType{
submitted, edited, dismissed
submitted, edited, dismissed, created
}

//PushEvent
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/thirtydegreesray/openhub/ui/adapter/ActivitiesAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ private String getPullRequestReviewEventStr(String action){
return getString(R.string.edited_pull_request_review_at);
case dismissed:
return getString(R.string.dismissed_pull_request_review_at);
case created:
return getString(R.string.created_pull_request_review_at);
default:
return getString(R.string.submitted_pull_request_review_at);
}
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values-zh-rCN/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@
<string name="submitted_pull_request_review_at">提交拉取请求审查在 %s</string>
<string name="edited_pull_request_review_at">编辑拉取请求审查在 %s</string>
<string name="dismissed_pull_request_review_at">取消拉取请求审查在 %s</string>
<string name="created_pull_request_review_at">创建拉取请求审查在 %s</string>
<string name="undo">撤销</string>
<string name="no_bookmarks">没有书签</string>
<string name="no_trace">没有足迹</string>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values-zh-rTW/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@
<string name="submitted_pull_request_review_at">提交拉取請求審查於 %s</string>
<string name="edited_pull_request_review_at">編輯拉取請求審查在 %s</string>
<string name="dismissed_pull_request_review_at">取消拉取请求审查於 %s</string>
<string name="created_pull_request_review_at">創建拉取请求审查於 %s</string>
<string name="undo">取消</string>
<string name="no_bookmarks">沒有書籤</string>
<string name="no_trace">無追蹤</string>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@
<string name="submitted_pull_request_review_at">Submitted pull request review at %s</string>
<string name="edited_pull_request_review_at">Edited pull request review at %s</string>
<string name="dismissed_pull_request_review_at">Dismissed pull request review at %s</string>
<string name="created_pull_request_review_at">Created pull request review at %s</string>

<string name="undo">Undo</string>
<string name="no_bookmarks">No bookmarks</string>
Expand Down