Fix use of deprecated Rc:would_unwrap #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling with rustc 1.19.0-nightly (e17a1227a 2017-05-12) fails due to the use of Rc::would_unwrap, https://doc.rust-lang.org/std/rc/struct.Rc.html says this is deprecated in favor of strong_count, error:
I changed it to Rc:strong_count(inner) == 1, based on the comment in rust-lang/rust#27718 (comment). This fixes the error although I'm not 100% sure it is correct, unable to test since linkage fails to a different reason (#67) update: able to run steven now, but it panics, I am not sure if it is related (brand new to rust): #69