update neoforge version, code clean

build.gradle

@@ -1,11 +1,9 @@
 plugins {
-    id "dev.architectury.loom" version "1.4-SNAPSHOT"
+    id "dev.architectury.loom" version "1.5-SNAPSHOT"
     id "maven-publish"
 }
 
-sourceCompatibility = targetCompatibility = JavaVersion.VERSION_17
-
-archivesBaseName = project.archives_base_name
+base.archivesName = project.archives_base_name
 version = "${project.mod_version}+mc${project.minecraft_version}"
 group = project.maven_group
 
@@ -39,6 +37,9 @@ tasks.withType(JavaCompile) {
 }
 
 java {
+    sourceCompatibility = JavaVersion.VERSION_17
+    targetCompatibility = JavaVersion.VERSION_17
+
     withSourcesJar()
 }
 

gradle.properties

@@ -5,11 +5,11 @@ loom.platform=neoforge
 
 # Base properties
     minecraft_version=1.20.4
-    neoforge_version=20.4.169
+    neoforge_version=20.4.234
     yarn_mappings=1.20.4+build.3
 
 # Mod Properties
-    mod_version=0.1.1
+    mod_version=0.1.2
     maven_group=org.thinkingstudio.forged_networking
     archives_base_name=ForgedNetworking
     mod_id=forged_networking

src/main/java/net/fabricmc/fabric/impl/networking/NetworkingImpl.java

@@ -16,6 +16,7 @@
 
 package net.fabricmc.fabric.impl.networking;
 
+import net.neoforged.fml.loading.FMLLoader;
 import org.slf4j.Logger;
 
 import net.minecraft.util.Identifier;
@@ -35,7 +36,7 @@ public final class NetworkingImpl {
 	 */
 	public static final boolean FORCE_PACKET_SERIALIZATION = Boolean.parseBoolean(System.getProperty(
 			"fabric-api.networking.force-packet-serialization",
-			Boolean.toString(ForgedNetworkingAPI.isDevelopmentEnvironment())));
+			Boolean.toString(!FMLLoader.isProduction())));
 
 	/**
 	 * Id of packet used to register supported channels.

src/main/java/org/thinkingstudio/forged/networking/ForgedNetworkingAPI.java

@@ -27,14 +27,14 @@ public ForgedNetworkingAPI() {
             ClientNetworkingImpl.clientInit();
         }
 
-        if (ForgedNetworkingAPI.isDevelopmentEnvironment()) {
+        if (!FMLLoader.isProduction()) {
             NeoForge.EVENT_BUS.addListener(EventPriority.HIGHEST, RegisterCommandsEvent.class, event -> {
                 if (SharedConstants.isDevelopment) {
                     // Command is registered when isDevelopment is set.
                     return;
                 }
 
-                if (!ForgedNetworkingAPI.isDevelopmentEnvironment()) {
+                if (FMLLoader.isProduction()) {
                     // Only register this command in a dev env
                     return;
                 }
@@ -43,8 +43,4 @@ public ForgedNetworkingAPI() {
             });
         }
     }
-
-    public static boolean isDevelopmentEnvironment() {
-        return !FMLLoader.isProduction();
-    }
 }