Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/cd: upgrade actions to v4 to avoid NodeJS warning #39

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

MashyBasker
Copy link

@MashyBasker MashyBasker commented Aug 9, 2024

This PR upgrades actions/checkout from v2 to v4 in the check-unicode.yml workflow, addressing warnings caused by Node.js 12 deprecation. The upgrade uses Node.js 16, eliminating the warnings.

Copy link
Owner

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some helpful content in your commit message?

What I see is for the "check-unicode" CI Action, 2 warnings appear as "Annotations". For example, https://github.com/ThinkOpenly/sail-riscv/actions/runs/10198111590.

The error text is:

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

So, please add some content that says that the "check-unicode" CI action is emitting warnings, show the warnings text, explain that it is caused by the version of node.JS used in "v2" and that upgrading from "v2" to "v4" addresses the issue.

@ThinkOpenly
Copy link
Owner

Sorry I wasn't clear. I think you added some contextual information in the PR description. That is helpful, but could you add the same text into the commit message? Commit messages persist as history within the git repository in the log, so are visible in any clones. We always want to convey the issue seen and the solution to future developers.

Change description:

- Upgrade actions/checkout from v2 to v4
- Addresses the warnings caused by NodeJS 12 deprecation in
  actions/checkout
- actions/checkout v4 uses NodeJS 16

Signed-off-by: Maharshi Basu <[email protected]>
@ThinkOpenly ThinkOpenly merged commit 12267d1 into ThinkOpenly:JSON Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants