Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names for base instructions #37

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

Linda-Njau
Copy link

No description provided.

Copy link
Owner

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There is a lot of subjectivity here, and the source manual is sometimes inconsistent, so I get to do it my way! ;-)
In general:

  • all lower case
  • try to treat the mnemonic as an initialism, such that each letter turns directly into a word starting with that letter
  • keep the primary action as the first word if there is a choice

For "sla", "shift left arithmetic" is preferred over "arithmetic left shift", for example.

model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
model/riscv_insts_base.sail Outdated Show resolved Hide resolved
@Linda-Njau
Copy link
Author

Changed and squashed.

model/riscv_insts_base.sail Outdated Show resolved Hide resolved
@Linda-Njau
Copy link
Author

I've updated the names to lowercase as we discussed.

@ThinkOpenly ThinkOpenly merged commit d726e29 into ThinkOpenly:JSON Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants