fix(core): do not throw when an exception lifecycleScope is null

ThibaultBee · Aug 26, 2024 · ab7784c · ab7784c
1 parent 7e712ac
commit ab7784c
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt b/core/src/main/java/io/github/thibaultbee/streampack/views/PreviewView.kt
@@ -92,12 +92,10 @@ class PreviewView @JvmOverloads constructor(
          */
         set(value) {
             stopPreviewInternal()
+            field = value
             value?.let {
-                lifecycleScope?.launch {
-                    startPreviewInternal(it, it.camera, size)
-                }
+                startPreviewIfReady(it, size, false)
             }
-            field = value
         }
 
     /**
@@ -311,6 +309,7 @@ class PreviewView @JvmOverloads constructor(
                     listener?.onPreviewStarted()
                 } else {
                     Logger.w(TAG, "Invalid surface")
+                    listener?.onPreviewFailed(IllegalStateException("Invalid surface"))
                 }
             }
         } catch (e: CancellationException) {