Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mission - Rewrite Surrender function #662

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Mission - Rewrite Surrender function #662

merged 1 commit into from
Jan 16, 2024

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Jan 11, 2024 •
edited
Loading

  • Did a rewrite of it because I didn't like how un-readable it was.
  • Now first checks the minimum distance for surrender, if it's false it exits and doesn't check anything else.
  • Converted number checking in if statements to simple bools. (surrender chance / rally chance)
  • Added OCAP events for Surrendering & Rallying.

My tests all show it working unless there's some weird edgecase im not seeing.

@Mike-MF Mike-MF requested a review from jonpas January 11, 2024 14:19
@jonpas jonpas added this to the 2.1.0 milestone Jan 16, 2024
@jonpas jonpas changed the title Mission - Update Surrender function Mission - Rewrite Surrender function Jan 16, 2024
@jonpas jonpas merged commit d62869b into master Jan 16, 2024
3 checks passed
@jonpas jonpas deleted the surrender-tweaks branch January 16, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-MF @jonpas