Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed main package documentation from .Rd file to .R file #87

Merged

Conversation

D-Maar
Copy link
Collaborator

@D-Maar D-Maar commented Jan 18, 2024

I didn't inlcude
@Aliases phylosim-package
@doctype package
as it is stated in the DHARMA package, since this throws the warning "@doctpye is deprecated". I used
@Keywords internal
"PACKAGE"
since that seems to be the new standard and unlike to tahminas post it doesnt seem to add a automated documention from the description. It seems to still rely on the information from the .R file Or maybe I'm understanding the idea behind using
@Aliases phylosim-package
@doctype package
wrong.
Do we need to have also an documentation when calling "?PhyloSim-package" ?

D-Maar and others added 3 commits January 18, 2024 13:08
I didn't inlcude
@Aliases phylosim-package
@doctype package
as it is stated in the DHARMA package, since this throws the warning "@doctpye  is deprecated".
I used
@Keywords internal
"_PACKAGE_"
since that seems to be the new standard and unlike to tahminas post it doesnt seem to add a  automated documention from the description. It seems to still rely on the information from the .R file
Or maybe I'm understanding the idea behind using
@Aliases phylosim-package
@doctype package
wrong.
Do we need to have also an documentation when calling "?PhyloSim-package" ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warum ist das doppelt?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.registration = TRUE hat gefehlt; habs gefixt und commited

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code muss in backtick `

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ist überall gemacht. Hab außerdem, während ich jedes Script nochmal überprüft habe die examples gleich outsourced

@florianhartig
Copy link
Member

  1. Also wegen der Syntax mit dem package keine Ahnung, aber wenn's funktioniert ist mir auch egal, probier doch im Zweifel noch mal

  2. check mal deine Roxygen Version

  3. Siehe Kommentare in den Files

D-Maar and others added 6 commits January 18, 2024 15:29
I tested wheter @doctype is deprecated and if use @doctype i get the warning:
✖ PhyloSim-package.R:28: `@docType "package"` is deprecated.
ℹ Please document "_PACKAGE" instead.

I use roxygen version 7.3.0

I also tested whether it uses the information in DESCRIPTION or in the .R file by changing both @descrption arguments and starting the documentation and it did use the changes from the .R file
…e.g. code should be places in ``); Also outsourced help into the examples folder
@florianhartig
Copy link
Member

OK, die Tests passen jetzt aber failen wegen der dependencies ... könnten wir im yaml mit Hand nachinstallierten aber da wir das eh als nächste lösen müssten würde ich das jetzt erst mal ignorieren, auch wenns schade ist dass es nicht automatisch geht.

Hast du mal mit Hand getestet?

@florianhartig
Copy link
Member

Ich teste gerade und merge dann!

@florianhartig
Copy link
Member

OK, das funktioniert auch nicht aber ich merge jetzt einfach erst mal, müssen wir dann fixen

@florianhartig florianhartig merged commit b8c68b9 into master Jan 19, 2024
0 of 6 checks passed
@florianhartig florianhartig deleted the Change-PhyloSim-package.RD-to-R-file-with-Roxygen branch January 19, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants