. #5

RohanBhattaraiNP · 2024-03-08T06:01:01Z

No description provided.

I will continue adding the modules. Currently, It only has UI design.

Theodlz

Hi Rohan! Thanks a lot for opening the PR! I left a bunch of comments. Mostly things you need to address once and keep as good habits going forward whenever you write code. It will help you a lot in the future.

Also, there is no documentation explaining how to run this, and the dependencies you added (like tkinter for example) have not been added to the requirements.txt. Don't forget to also put a title to your PRs, and a short description. Otherwise, your reviewer has no idea what this is about!!!

Theodlz · 2024-03-12T18:54:15Z

surf/file

@@ -0,0 +1 @@
+


Empty file, please remove

Theodlz · 2024-03-12T18:55:21Z

GUI.py

+    # Plotting histograms
+    ax1.clear()
+    ax1.hist(data[:, 0], color='skyblue', bins=10)
+    ax1.set_title('Histogram 1')
+    ax1.set_xlabel('Values')
+    ax1.set_ylabel('Frequency')
+    ax1.grid(True)
+
+    ax2.clear()
+    ax2.hist(data[:, 1], color='salmon', bins=10)
+    ax2.set_title('Histogram 2')
+    ax2.set_xlabel('Values')
+    ax2.set_ylabel('Frequency')
+    ax2.grid(True)
+
+    # Plotting corner plot
+    ax3.clear()
+    pair_plot = sns.pairplot(pd.DataFrame(data))
+    pair_plot.fig.suptitle('Corner Plot', y=1.02)  # Set title
+    pair_plot.fig.set_size_inches(6, 6)  # Adjust size


worth splitting this plot_data method in 2 submethods (for each plot type) that you call here. Will keep the code readable going forward

Theodlz · 2024-03-12T18:56:16Z

GUI.py

+'''This is the basic code that I started for the UI design
+It does not have any working feature, I will slowly start adding feature. 
+Currently I am trying to build the basic GUI where I will continue adding other
+modules as told by Ashish.'''


This code is open-source (i.e. visible by everyone who wants to run it), so no need to add things like "as told by Ashish" 😉

Theodlz · 2024-03-12T18:57:10Z

GUI.py

+import tkinter as tk
+from tkinter import ttk
+from datetime import date
+import matplotlib.pyplot as plt
+from matplotlib.backends.backend_tkagg import FigureCanvasTkAgg
+import seaborn as sns
+import numpy as np
+import pandas as pd


Please keep your imports PEP compliant, meaning classic imports (import ...) first (sorted alphabetical) and then from ... import ....

Theodlz · 2024-03-12T18:57:35Z

GUI.py

+Currently I am trying to build the basic GUI where I will continue adding other
+modules as told by Ashish.'''
+
+def plot_data():


please add docstrings to your methods. Small effort now, but will pay longterm when you go back to your old code!

Theodlz · 2024-03-12T18:58:05Z

GUI.py

+
+    ax2.clear()
+    ax2.hist(data[:, 1], color='salmon', bins=10)
+    ax2.set_title('Histogram 2')


Might want the title to be an argument you pass to the plot_data() method or smth

Theodlz · 2024-03-12T18:58:47Z

GUI.py

+
+    canvas.draw()
+
+# Creating main window


Please wrap everything below in a main method, that you call in if __name__ == "main":

and this is where you should add a docstring explaining what all this will do!

RohanBhattaraiNP · 2024-03-18T00:16:25Z

.

Theodlz · 2024-03-18T00:18:50Z

@RohanBhattaraiNP can you please add description and a title for your PR when you have the chance? Hard for everyone to keep track of things if you don't. Thanks

RohanBhattaraiNP · 2024-03-18T00:21:02Z

I have tried updating the code based on your feedback.

Theodlz · 2024-03-28T18:11:49Z

I have tried updating the code based on your feedback.

Thanks Rohan, but the pull request still has no title or description, so I can't really review something without knowing what it is about! Please address that comment too (which I left in the first review). Naming a PR with a dot isn't quite useful...

RohanBhattaraiNP · 2024-03-29T17:55:23Z

I will update the code today, with other improvements and with title and description. I apologize for the oversight. Best, Rohan Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Theophile du Laz ***@***.***> Sent: Thursday, March 28, 2024 11:57:10 PM To: Theodlz/frigate ***@***.***> Cc: Bhattarai, Rohan (Rohan) ***@***.***>; Mention ***@***.***> Subject: Re: [Theodlz/frigate] . (PR #5) I have tried updating the code based on your feedback. Thanks Rohan, but the pull request still has no title or description, so I can't really review something without knowing what it is about! Please address that comment too (which I left in the first review). Naming a PR with a dot isn't quite useful... — Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BEOZFJQIDPLHOTI4J3A2NULY2RMPVAVCNFSM6AAAAABEMIHNKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVHAZDMMBVGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Theodlz · 2024-04-11T22:02:23Z

I will update the code today, with other improvements and with title and description. I apologize for the oversight. Best, Rohan Get Outlook for iOShttps://aka.ms/o0ukef
…
________________________________ From: Theophile du Laz @.> Sent: Thursday, March 28, 2024 11:57:10 PM To: Theodlz/frigate @.> Cc: Bhattarai, Rohan (Rohan) @.>; Mention @.> Subject: Re: [Theodlz/frigate] . (PR #5) I have tried updating the code based on your feedback. Thanks Rohan, but the pull request still has no title or description, so I can't really review something without knowing what it is about! Please address that comment too (which I left in the first review). Naming a PR with a dot isn't quite useful... — Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEOZFJQIDPLHOTI4J3A2NULY2RMPVAVCNFSM6AAAAABEMIHNKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVHAZDMMBVGU. You are receiving this because you were mentioned.Message ID: @.***>

Any updates @RohanBhattaraiNP?

RohanBhattaraiNP · 2024-04-12T17:50:28Z

I was busy on classes because of start of term. I will do an update on weekend. Best, Rohan Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Theophile du Laz ***@***.***> Sent: Thursday, April 11, 2024 3:02:44 PM To: Theodlz/frigate ***@***.***> Cc: Bhattarai, Rohan (Rohan) ***@***.***>; Mention ***@***.***> Subject: Re: [Theodlz/frigate] . (PR #5) I will update the code today, with other improvements and with title and description. I apologize for the oversight. Best, Rohan Get Outlook for iOShttps://aka.ms/o0ukef …

________________________________ From: Theophile du Laz @.> Sent: Thursday, March 28, 2024 11:57:10 PM To: Theodlz/frigate @.> Cc: Bhattarai, Rohan (Rohan) @.>; Mention @.> Subject: Re: [Theodlz/frigate] . (PR #5<#5>) I have tried updating the code based on your feedback. Thanks Rohan, but the pull request still has no title or description, so I can't really review something without knowing what it is about! Please address that comment too (which I left in the first review). Naming a PR with a dot isn't quite useful... — Reply to this email directly, view it on GitHub<#5 (comment)<#5 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEOZFJQIDPLHOTI4J3A2NULY2RMPVAVCNFSM6AAAAABEMIHNKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVHAZDMMBVGU. You are receiving this because you were mentioned.Message ID: @.***> Any updates @RohanBhattaraiNP<https://github.com/RohanBhattaraiNP>? — Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BEOZFJQVHYOOB6BGDA6BUXLY44CAJAVCNFSM6AAAAABEMIHNKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGYZTEOJTHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Added responsiveness and fitting properly in screen.

RohanBhattaraiNP · 2024-04-17T21:52:15Z

Added Responsiveness and fitting properly on the screen. Added comments.

RohanBhattaraiNP added 2 commits March 5, 2024 01:34

Create file

cc32252

Basic GUI design

af374ca

I will continue adding the modules. Currently, It only has UI design.

Theodlz requested changes Mar 12, 2024

View reviewed changes

Update GUI.py

ecca3f4

Update GUI.py

c32403a

Added responsiveness and fitting properly in screen.

RohanBhattaraiNP added 2 commits April 26, 2024 16:10

Create ui.py

6191876

Update ui.py

f844aa5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

. #5

. #5

RohanBhattaraiNP commented Mar 8, 2024

Theodlz left a comment

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

Theodlz Mar 12, 2024

RohanBhattaraiNP commented Mar 18, 2024

Theodlz commented Mar 18, 2024

RohanBhattaraiNP commented Mar 18, 2024

Theodlz commented Mar 28, 2024

RohanBhattaraiNP commented Mar 29, 2024 via email

Theodlz commented Apr 11, 2024

RohanBhattaraiNP commented Apr 12, 2024 via email

RohanBhattaraiNP commented Apr 17, 2024

. #5

Are you sure you want to change the base?

. #5

Conversation

RohanBhattaraiNP commented Mar 8, 2024

Theodlz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RohanBhattaraiNP commented Mar 18, 2024

Theodlz commented Mar 18, 2024

RohanBhattaraiNP commented Mar 18, 2024

Theodlz commented Mar 28, 2024

RohanBhattaraiNP commented Mar 29, 2024 via email

Theodlz commented Apr 11, 2024

RohanBhattaraiNP commented Apr 12, 2024 via email

RohanBhattaraiNP commented Apr 17, 2024