Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Keep Sticky-Header hidden on page load #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BMOv2600
Copy link

@BMOv2600 BMOv2600 commented Sep 4, 2015

Sticky header is visible momentarily after the page initially loads. This change keeps the header hidden until visitors scroll to the user param.

Sticky header is visible momentarily after the page initially loads. This change keeps the header hidden until visitors scroll to the user param.
@slobodan
Copy link
Member

slobodan commented Sep 8, 2015

@BMOv2600 not sure what you mean. Header shows up when you scroll down to a certain point of the page, not immediately on page load.

@BMOv2600
Copy link
Author

BMOv2600 commented Sep 8, 2015

@slobodan That was not my experience until I made these changes. Before that, the 'thsp-sticky-header' div would appear for a split second once the site loaded (it looked like because the margin rule on line 22 didn't fire early enough), move above the visible area in the browser, then reappear on a scroll far enough down the page.

Could be unique to my setup though.

Would the changes in my PR impede the plugin's function somehow? It's an improvement for me.

@slobodan
Copy link
Member

Looks good, I'll take a detailed look over the weekend.

@slobodan
Copy link
Member

Can you change both numbers to 50 in your pull request (currently 100 and 60) and also include updated public.min.js so I can merge it? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants