feat: allow plugins to implement custom drm provider #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow plugins to provide DRM manger to create custom implementations, eg. using SKD from DRM providers
freeboub
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Code looks good, but I am not fan of this solution (I understand the need by the way).
My issue here is that you introduced a dependency between RNVplugin and Exoplayer or AVPlayer.
The day we will support other players, The RNVPlugin will not be compatible with new player implementation.
We have 2 choices to handle that, either
- remove dependency from RNVPlugin and make a generic api (which looks really tricky on my side).
- move the DRM management to RNVExoplayerDrmPlugin / RNVAVPlayerDrmPlugin which clearly highlight the player dependency
| "@callstack/react-native-visionos": "^0.73.0", | ||
| "@react-native-picker/picker": "2.8.1", | ||
| "react": "18.2.0", | ||
| "react-native": "0.73.2", |
There was a problem hiding this comment.
here you upgrade react native, split your pr please !
| UUID uuid = Util.getDrmUuid(drmProps.getDrmType()); | ||
| if (uuid != null) { | ||
| try { | ||
| DebugLog.w(TAG, "drm buildDrmSessionManager"); |
There was a problem hiding this comment.
Not your code, but I think we should remove this warning (which is not a warning in fact)
Suggested change
| DebugLog.w(TAG, "drm buildDrmSessionManager"); | |
| DebugLog.d(TAG, "drm buildDrmSessionManager"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have changed DRM logic to allow plugins to implement custom drm provider. It should not have impact for current users
Motivation
Allow plugins to implement custom drm provider. Eg. implement DRM SDK form 3th party DRM providers
Changes
Test plan
I have ran our DRM example on both iOS & Android physical devices to confirm that "default" DRM works