Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/fix Decentlab devices #845

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

decentlab
Copy link
Contributor

Summary

Added 4 new devices and fixed minor cosmetic issues.

Changes

  • Added Decentlab dl-csw2, dl-ifd, dl-ilt and dl-isd.
  • Fixed sensor name potentiometer to distance in dl-zn1 and dl-zn2.
  • Fixed typos in the title of dl-dws and dl-pr36.

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

Release Notes

@Jaime-Trinidad
Copy link
Contributor

Hi @decentlab please sign the CLA

@johanstokking johanstokking merged commit b441df4 into TheThingsNetwork:master Nov 19, 2024
2 checks passed
@decentlab
Copy link
Contributor Author

Hi @decentlab please sign the CLA

Hi @Jaime-Trinidad, how do we do that? I tried to find some hints without success. Thanks.

@johanstokking
Copy link
Member

@decentlab it was already signed, I think the bot was behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants