Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yobiiq as vendor #840

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

dhakke
Copy link
Contributor

@dhakke dhakke commented Oct 30, 2024

Summary

Added Yobiiq as vendor and the SD1001 device./

Changes

  • ...
  • ...

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@yobiiq-fostin
Copy link
Contributor

Hi @johanstokking @Jaime-Trinidad
Could you please approve and validate the workflow for our PR?
Thank you for your time and feedback!

@Jaime-Trinidad
Copy link
Contributor

Hi @dhakke please update the branch so I can merge it. Thanks

@Jaime-Trinidad
Copy link
Contributor

@dhakke please run make validate fmt

@yobiiq-fostin
Copy link
Contributor

Hi @Jaime-Trinidad
The branch is updated. You can now merge it.

@johanstokking johanstokking merged commit a084a19 into TheThingsNetwork:master Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants