Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links for LBT, non LBT AS regions #29

Closed
wants to merge 1 commit into from

Conversation

terrillmoore
Copy link
Contributor

Fix #28 by creating lbt and non-lbt versions of files, and (some but not all) countries needing one or the other.

@terrillmoore
Copy link
Contributor Author

Using a Posix timezone-like approach. Files are hardlinks (and show up as such on my WIndows system under git bash, but this should perhaps be checked).

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting @terrillmoore !

Those hard links didn't make it.

I would go for the per-country approach, and keep references in a subdirectory so we can pick from there if we add a new country that we can base on an existing frequency plan.

@egourlao
Copy link

egourlao commented Feb 6, 2018

It doesn't seem that Git supports symlinks at all: https://stackoverflow.com/questions/954560/how-does-git-handle-symbolic-links I agree with @johanstokking on going for an approach with less files, and more documentation.

As an FYI, V3's new lightweight frequency plans format supports extending another frequency plan, which means we'll have less verbose files for this kind of cases.

@terrillmoore
Copy link
Contributor Author

OK, I'll look at revising and resubmitting. May take a few days, got a bit of a backlog here to get through.

@johanstokking johanstokking self-assigned this Feb 6, 2018
@egourlao egourlao removed their request for review November 28, 2018 13:11
@egourlao egourlao removed their assignment Nov 28, 2018
@johanstokking
Copy link
Member

@terrillmoore we have a new repository for V3 frequency plans: https://github.com/TheThingsNetwork/lorawan-frequency-plans. It allows you to easily add frequency plans with a base-id, so you can enable listen-before-talk on selected plans. Please re-open this issue there if this is still relevant for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants