Flexible LOD scale factors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks good to me, you can merge this once the GCC build is tested 👍 |
CallumDev
approved these changes
Jul 10, 2023
|
The GCC build works. Additional documentation is still needed for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to rely on hard coded float constants in Freelancer.exe, the
lod_scaleoption now supports arbitrary float values. For example, when entering values such as42,6.5, and512.1337the scale function will use that as the scale factor and it'll work just fine. I've currently set the limit to 1,000,000 as I had to draw the line somewhere.I should mention that I haven't properly tested the new feature with GCC yet, so please check if that still works. I'm also not the best at documenting ini files, so I'll leave that up to you @CallumDev.
I've also cleaned up Common.h a little bit.