Fix use of incorrect method when resolving CNAMES #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking
CNAME
records, the code calls:Which results in an integer argument being given for the
name_server
argument in theresolver.query
method which has the signature:And causes an error to be raised in
dnslib
:It seems from the call signature intended to be recursive call to the
check
method itself with a preservation of the retry count so that's what I put in.