Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github.com to known hosts #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irekkosek
Copy link

@irekkosek irekkosek commented Jun 12, 2023

This pull request resolves a reproducibility problem coming up after trying to
follow Prime's actions in this official Frontend Masters Developer Productivity presentiation video:
https://youtu.be/qd3mfYS_Xow?t=247
when trying to run playbook with "-t dotfiles" in nvim-computer image, on step related to personal projects
we get "Host key verification failed" error when we first hit github.com over ssh (This is probably due execution sequence changes introduced to local.yml in commit 5b1d263).
This is resolved by adding github.com to known hosts in ssh.yml before trying to clone any repositories over ssh.

@irekkosek
Copy link
Author

irekkosek commented Jun 14, 2023

There has been one thing bothering me about it and i thought i could add it here.
Previously this "error" might have not risen up to the surface due to the nature of the whole solution.
If this was used as a quick setup tool, the connection to github was first instantiated when downloading this repo and thus github.com was already added in known_hosts, so by the time user executed ansible-playbook there was no problem with offending host key, as it was already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant