Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dart Sass, instead of deprecated Node Sass. (PP-691) #12

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tdilauro
Copy link
Collaborator

@tdilauro tdilauro commented Nov 6, 2023

Description

Replaces the Node Sass dev dependency with Dart Sass.

Motivation and Context

Node Sass is not yet supported on Apple Silicon Macs, at least not with Node 18.

Also, LibSass and packages that depend upon it, like Node Sass, are now deprecated.

[Jira PP-691]

How Has This Been Tested?

  • Manually tested on both Intel and Apple Silicon Macs and was able to perform the following:
  • CI passed for this feature branch.

Checklist:

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from ray-lee November 6, 2023 18:33
Copy link
Contributor

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tdilauro tdilauro merged commit 5dba867 into main Nov 7, 2023
2 checks passed
@tdilauro tdilauro deleted the feature/deprecate-node-sass branch November 7, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants