Update mypy configuration for tests #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
chore/mypy-config-tests
branch
from
cf2fecd
to
b286414
Compare
jonathangreen
force-pushed
the
chore/mypy-config-tests
branch
from
aa92fd1
to
869b407
Compare
jonathangreen
force-pushed
the
chore/mypy-config-tests
branch
from
869b407
to
5fc8261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update mypy configuration for our tests to:
union-attrcheckwarn-unreachableMotivation and Context
Both of these flags don't provide a lot of value in our tests, and cause us to have to add a bunch of ignore comments, so just disabling them seems like a better option.
How Has This Been Tested?
Checklist