Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send only IDs for custom list manual update entries. (PP-2050) #143

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

tdilauro
Copy link
Contributor

@tdilauro tdilauro commented Jan 16, 2025

Description

  • Send only ids for custom list manual update items in the "entries" and "deletedEntries" properties, rather than including all the metadata associated with the them.
  • Exclude items that are already members of the list from the updated "entries" payload.

Motivation and Context

  • Payloads included many unnecessary properties for each list item entry, when only the id is needed for additions and deletions.
  • The update payload included all loaded current entries, even those that were already members of the list; so, if the use loaded many pages of the list, many unneeded members could be included in the request. This would lead to:
  • Larger requests.
  • Unnecessary processing.

[Jira PP-2059]

How Has This Been Tested?

Checklist:

  • [N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro added the bug Something isn't working label Jan 16, 2025
@tdilauro tdilauro requested review from a team and PoorBillyPilgrim January 16, 2025 20:34
@tdilauro tdilauro merged commit c88bda3 into main Jan 18, 2025
1 check passed
@tdilauro tdilauro deleted the bugfix/reduce-custom-list-update-payload-size branch January 18, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants