Updated Readium version #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io7m
reviewed
Nov 20, 2023
| @@ -67,8 +67,6 @@ dependencies { | |||
| implementation(libs.kotlinx.coroutines.android) | |||
| implementation(libs.kotlinx.coroutines.core.jvm) | |||
| implementation(libs.logback.android) | |||
| implementation(libs.nano.httpd) | |||
| implementation(libs.nano.httpd.nanolets) | |||
| implementation(libs.palace.theme) | |||
io7m
reviewed
Nov 20, 2023
...mplified.r2.vanilla/src/main/java/org/librarysimplified/r2/vanilla/internal/SR2Controller.kt
Show resolved
Hide resolved
io7m
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
This PR updates the app to support the latest version of Readium.
Why are we doing this? (w/ JIRA link if applicable)
There's a feature request to update the Readium version.
How should this be tested? / Do these changes have associated tests?
Follow the testing steps of this PR.
Dependencies for merging? Releasing to production?
This PR also needs to be merged
Have you updated the changelog?
Yes
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
Tested by @nunommts