Chore: Use binstubs in bin/test

[MaoShizhong]

Because

Some people (coughcough) somehow had persistent issues with running rspec globally or via bundle exec rspec. We have a dedicated bin/rspec which does work for everyone so far so that ought to be used in bin/test.

This PR

• Fixes typo in yarn lint command
• Replaced rspec command with rspec binstub

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

• I have thoroughly read and understand The Odin Project Contributing Guide
• The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
  • Feature - adds new or amends existing user-facing behavior
  • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
  • Fix - bug fixes
• The Because section summarizes the reason for this PR
• The This PR section has a bullet point list describing the changes in this PR
• I have verified all tests and linters pass after making these changes.
• If this PR addresses an open issue, it is linked in the Issue section
• If applicable, this PR includes new or updated automated tests

[MaoShizhong]

Would it be sensible to replace the rubocop and erblint commands with the appropriate binstubs as well?
I'm not 100% certain of the most ideal way to write the bin/erblint command to lint all files if we do want that changed as well.

+ would you want stylelint added to the script?

[KevinMulhern]

Thanks for doing this @MaoShizhong 🔥

Would it be sensible to replace the rubocop and erblint commands with the appropriate binstubs as well?

I think so, we're using them on CI so they should be the safest option.

I'm not 100% certain of the most ideal way to write the bin/erblint command to lint all files if we do want that changed as well.

I wish it did all files by default, but we should be able to pass a flag in the string:

system 'bin/erblint --lint-all'

• would you want stylelint added to the script?

Yes please!

[KevinMulhern]

Great stuff @MaoShizhong!