Feature: Convert lesson preview to Hotwire #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMulhern
force-pushed
the
feature/convert-lesson-preview-page-to-hotwire
branch
from
cee8f56
to
2014998
Compare
KevinMulhern
added
the
Type: Enhancement
KevinMulhern
added
the
create-review-app
github-actions
bot
removed
the
create-review-app
KevinMulhern
force-pushed
the
feature/convert-lesson-preview-page-to-hotwire
branch
from
2014998
to
7c1cc00
Compare
Because: * We can simplify the preview feature code with Hotwire * New and improved share preview UX This commit: * Moves input and html preview tabs to rails views. * Adds reusable tabs and autosubmit and clipboard controllers. * Adds a share modal that is handled by a new preview share controller to keep persisting separate from displaying. * Amends our modal to display center of the screen on mobile. * Increases the share preview rate limit to 5 per minute - it may be clicked more now that its easier to find above the preview.
KevinMulhern
force-pushed
the
feature/convert-lesson-preview-page-to-hotwire
branch
from
7c1cc00
to
6f838aa
Compare
CouchofTomato
approved these changes
Sep 3, 2023
KevinMulhern
deleted the
feature/convert-lesson-preview-page-to-hotwire
branch
ZachBaird
pushed a commit
to ZachBaird/theodinproject
that referenced
this pull request
Sep 4, 2023
Because: * We can simplify the preview feature code with Hotwire * New and improved share preview UX https://github.com/TheOdinProject/theodinproject/assets/7963776/5de1cdee-3301-4bc1-9b35-783b098aadfc This commit: * Moves input and html preview tabs to rails views. * Adds reusable tabs and autosubmit and clipboard controllers. * Adds a share modal that is handled by a new preview share controller to keep persisting separate from displaying. * Amends our modal to display center of the screen on mobile. * Increases the share preview rate limit to 5 per minute - it may be clicked more now that its easier to find above the preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
Screen.Recording.2023-09-01.at.09.49.47.mov
Closes: #4076
This commit: